Add docs for Prestodb to MySQL type mapping in MySQL Connector#21171
Add docs for Prestodb to MySQL type mapping in MySQL Connector#21171tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 16970a0...6cd105c.
|
steveburnett
left a comment
There was a problem hiding this comment.
Nice work, thanks! I have a few suggestions, but not many.
67aa86d to
5182d6c
Compare
@steveburnett Thanks !!! for review. |
5182d6c to
821fb00
Compare
kiersten-stokes
left a comment
There was a problem hiding this comment.
Looks good! I have one very minor formatting suggestion below
There was a problem hiding this comment.
The widths attribute here specifies the relative width of each column rather than some fixed value. I think we'd be safe to remove it (or, put 50, 50). This also has the happy side effect that the unnecessary wrapping of DECIMAL(P, S) in the "PrestoDB to MySQL type mapping" table will no longer occur
| :widths: 40, 50 |
| :widths: 40, 50 | |
| :widths: 50, 50 |
There was a problem hiding this comment.
Same here :)
| :widths: 40, 50 |
| :widths: 40, 50 | |
| :widths: 50, 50 |
457ccbf to
dfe558e
Compare
|
@tdcmeehan help to merge this and adding label as "pr bootcamp" what does that mean exactly? |
|
@tdcmeehan please help to review and let me know any more checks are to be done, help to merge. |
|
While I'm supportive of this documentation, can you prove to me (through tests or references to code) that it's an accurate listing of types? |
dfe558e to
6cd105c
Compare
|
@tdcmeehan please review and help to merge. |
|
@tdcmeehan please review |




No description provided.